[SceneKit] Make SCNMatrix4 column-major in .NET. Fixes #4652. #13695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implement a column-major version of SCNMatrix4 in .NET to match native code. * This was done by copying the existing SCMatrix4 implementation, and modify it as required (doing it with conditional compilation in the same file turned out to be quite messy, so I opted for using different files for legacy Xamarin and .NET). * There was one major change: the matrix inversion algorithm is new (copied from .NET instead), because the legacy Xamarin version showed strange results with some test values. * Add setters for SCNMatrix4.Column[0-3] for legacy Xamarin to match the .NET API. * Add CreateFromColumns methods for legacy Xamarin to match the .NET API. * Add tests for all the new API. Fixes xamarin#4652.
rolfbjarne
added
not-notes-worthy
This comment has been minimized.
This comment has been minimized.
dalexsoto
approved these changes
Jan 13, 2022
tj-devel709
reviewed
Jan 13, 2022
src/SceneKit/SCNMatrix4_dotnet.cs
Outdated
| pfloat d = -(2.0f * zFar * zNear) / (zFar - zNear); | ||
|
|
||
| result = new SCNMatrix4 (x, 0, 0, 0, | ||
| 0, y, 0, 0, |
There was a problem hiding this comment.
Spacing looks maybe different than desired
tj-devel709
reviewed
Jan 13, 2022
src/SceneKit/SCNMatrix4_dotnet.cs
Outdated
| SCNVector3 y = SCNVector3.Normalize (SCNVector3.Cross (z, x)); | ||
|
|
||
| SCNMatrix4 rot = new SCNMatrix4 (new SCNVector4 (x.X, y.X, z.X, 0.0f), | ||
| new SCNVector4 (x.Y, y.Y, z.Y, 0.0f), |
tj-devel709
approved these changes
Jan 13, 2022
|
CC @mattleibow in case this affects MAUI |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View dotnet API diffView dotnet legacy API diffAPI Current PR diffℹ️ API Diff (from PR only) (please review changes) View dotnet API diffView dotnet legacy API diffGenerator diffℹ️ Generator Diff (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results3 tests failed, 145 tests passed.Failed tests
Pipeline on Agent XAMBOT-1096.BigSur' |
|
Test failures are unrelated:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as required (doing it with conditional compilation in the same file turned out
to be quite messy, so I opted for using different files for legacy Xamarin and
.NET).
.NET instead), because the legacy Xamarin version showed strange results with
some test values.
Fixes #4652.